Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with new Kobo models #15

Merged
merged 6 commits into from
Dec 4, 2022
Merged

Conversation

lennie420
Copy link

Updating with new Kobo models currently available for purchase. Leaving Forma available as this is still a favourite amongst manga readers even though it is currently not available to purchase as seen on Kobo UK website.

Update the Kobo models to the current models available from Kobo. I have kept Kobo Forma as this is a popular device amongst manga readers even though it's currently unlisted from Kobo UK's site.
@darodi
Copy link
Owner

darodi commented Dec 1, 2022

Just having a thought about this pull request.
You are removing old profiles that some users may still be using.
It may be better to create an external file with profiles as in this other fork

https://github.com/rourien/kcc/blob/beta_release/profiles.csv

@darodi darodi self-requested a review December 1, 2022 21:46
@darodi darodi marked this pull request as draft December 1, 2022 21:48
@darodi darodi marked this pull request as ready for review December 1, 2022 22:13
@lennie420
Copy link
Author

I see, unfortunately not a programmer just thought having the old devices and none of the new ones was a bit strange and knew the original kcc hasn't been updated in a few years. Own a Kobo and don't have knowledge of the Kindle line-up that's why I didn't touch any of those devices.

@darodi
Copy link
Owner

darodi commented Dec 3, 2022

@lennie420

Thanks, I'll readd older models and merge your change today.
I'll also create another issue to be more flexible and allow to add new profiles in preferences/csv.

@darodi darodi merged commit 4e0a1a5 into darodi:beta_release Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants